Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the total number of feature flag combinations and progress #32

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Apr 23, 2020

Before:

$ cargo hack --each-feature --workspace
info: running `cargo check` on crate1
...
info: running `cargo check --no-default-features` on crate1
...
info: running `cargo check` on crate2
...

After:

$ cargo hack --each-feature --workspace
info: running `cargo check` on crate1 (1/10)
...
info: running `cargo check --no-default-features` on crate1 (2/10)
...
info: running `cargo check` on crate2 (6/10)
...

This is only enabled for --each-feature and --feature-powerset that may run the command multiple times with one crate.

Closes #27

@taiki-e taiki-e marked this pull request as ready for review April 23, 2020 18:36
@taiki-e
Copy link
Owner Author

taiki-e commented Apr 23, 2020

bors r

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

Build succeeded:

@bors bors bot merged commit 9d41eb7 into master Apr 23, 2020
@bors bors bot deleted the print-progress branch April 23, 2020 18:41
@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Oct 17, 2020
@taiki-e taiki-e mentioned this pull request Oct 17, 2020
bors bot added a commit that referenced this pull request Oct 17, 2020
68: Always print progress r=taiki-e a=taiki-e

Currently, progress is only printed when some options were specified (see #32), but I think it's better to always print it.

Before:
```console
$ cargo hack check --all
info: running `cargo check` on member1
...
info: running `cargo check` on member2
...
info: running `cargo check` on member3
...
```

After
```console
$ cargo hack check --all
info: running `cargo check` on member1 (1/3)
...
info: running `cargo check` on member2 (2/3)
...
info: running `cargo check` on member3 (3/3)
...
```

Co-authored-by: Taiki Endo <[email protected]>
@taiki-e taiki-e removed the C-enhancement Category: A new feature or an improvement for an existing one label Jan 6, 2021
@taiki-e taiki-e added the A-diagnostics Area: Messages for errors and warnings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors and warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: Add enumeration diagnostics to output
1 participant