Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate dynamic imports for icons-react #1081

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Generate dynamic imports for icons-react #1081

merged 2 commits into from
Sep 27, 2024

Conversation

timheerwagen
Copy link
Contributor

fixes #998

This PR generates a dynamic import for every Icon, so it can be used for lazy loading.

Also i had to use slash when building, because Windows could not read the joined path.

@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler-icons ✅ Ready (Inspect) Visit Preview Sep 26, 2024 11:44pm

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Lack of activity label May 23, 2024
@timheerwagen
Copy link
Contributor Author

Will this PR be merged, or should I make some changes?

@github-actions github-actions bot removed the stale Lack of activity label May 24, 2024
@devcshort
Copy link

I NEED this for my current project. Please merge it whoever needs to :'(

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Lack of activity label Jul 1, 2024
@timheerwagen
Copy link
Contributor Author

Still interested in this feature.

@github-actions github-actions bot removed the stale Lack of activity label Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Lack of activity label Aug 1, 2024
@codecalm codecalm removed the stale Lack of activity label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Lack of activity label Sep 8, 2024
@aminelemaizi
Copy link

aminelemaizi commented Sep 8, 2024 •
edited
Loading

I would love to have this feature, any chance to integrate this in the next release?

@github-actions github-actions bot removed the stale Lack of activity label Sep 9, 2024
@gDlugokecki
Copy link

Is there a chance somebody could merge this? This is valuable and highly desired!

@codecalm codecalm merged commit 7d1f101 into tabler:main Sep 27, 2024
2 of 3 checks passed
@codecalm
Copy link
Member

thank you for your help! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 dependencies 🔗 react package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Icon dynamically
5 participants
@timheerwagen @devcshort @aminelemaizi @gDlugokecki @codecalm