Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Svelte 5 #1162

Closed
4 of 30 tasks
hanszoons opened this issue Jun 17, 2024 · 1 comment · Fixed by #1167
Closed
4 of 30 tasks

Add support for Svelte 5 #1162

hanszoons opened this issue Jun 17, 2024 · 1 comment · Fixed by #1167
Assignees
@BG-Software-BG
Labels
bug Something isn't working pull-request Pull request available

Comments

@hanszoons
Copy link

Description

We are stuck on tabler icons version 2.4x, because of all the open Svelte issues, mostly related to tree shaking and performance..

To make matters worse, the svelte icons package currently has svelte@">=3 <5"as a peer dependency. 2.4x works fine with svelte 5 (and the non-standard imports we need to use to force them to bee tree shaking), but npm complains every step of the way.

Could you please add at least Svelte 5 support if the other issues are a less easy fix?

Package

  • @tabler/icons
  • @tabler/icons-eps
  • @tabler/icons-pdf
  • @tabler/icons-png
  • @tabler/icons-webfont
  • @tabler/icons-sprite
  • @tabler/icons-preact
  • @tabler/icons-react
  • @tabler/icons-react-native
  • @tabler/icons-solid
  • @tabler/icons-svelte
  • @tabler/icons-vue
  • Figma plugin
  • source/main
  • other/not relevant

Version

2.47

Browser

  • Chrome/Chromium
  • Firefox
  • Safari
  • Edge
  • iOS Safari
  • Opera
  • Other/not relevant

Operating system

  • Windows
  • Linux
  • macOS
  • ChromeOS
  • iOS
  • Android
  • Other/not relevant

Steps to reproduce

None

Checklist

  • I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
@hanszoons hanszoons added the bug Something isn't working label Jun 17, 2024
@hanszoons hanszoons changed the title Add support voor Svelte 5 Add support for Svelte 5 Jun 17, 2024
@BG-Software-BG BG-Software-BG self-assigned this Jun 18, 2024
@BG-Software-BG BG-Software-BG linked a pull request Jun 18, 2024 that will close this issue
Add support for Svelte 5 #1167
Merged
@BG-Software-BG BG-Software-BG added the pull-request Pull request available label Jun 18, 2024
@Laurens256
Copy link

In the meantime you can fix this issue by adding the following to your package.json

	"overrides": {
		"@tabler/icons-svelte": {
			"svelte": "^5.0.0-next.1"
		}
	},

(Or replace with whatever version you're using)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BG-Software-BG BG-Software-BG

Labels
bug Something isn't working pull-request Pull request available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Svelte 5 tabler/tabler-icons
3 participants
@BG-Software-BG @Laurens256 @hanszoons