Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout-rtl.html #1859

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

UnrivaledIr
Copy link

Enhanced RTL Demo: Replaced English Data with Farsi for Clarity

I've added some Persian data for RTL-demo
Copy link

changeset-bot bot commented Mar 30, 2024

⚠️ No Changeset found

Latest commit: 885c208

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ❌ Failed (Inspect) Mar 30, 2024 7:38am

Copy link
Collaborator

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work unfortunately.
The idea is good to use RTL content to show the RTL support.
But you change the generated HTML file and not the source file, your changes would be lost with the next update. The source file is here: https://github.com/tabler/tabler/blob/dev/src/pages/layout-rtl.html

And I don't think it can be fully translated without a lot of changes for this single use-case.

You would have to traverse through all Jekyll templates, layout and include files and make them translatable somehow.

What you could do is to change the page-header and page-title variables in the linked file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants