Declarative chest loot #4454
Open
Declarative chest loot #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yter/tModLoader into 1.4.4-declarative-chest-loot
|
Mod solely for testing this & updated ISH |
|
Source code for the former in case anyone wants to verify its accuracy |
|
Toss the source code for the mod in |
added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
Chest loot will now be declarative.
Why should this be part of tModLoader?
Currently mods can't even add loot to "rare" pools in chests with a constant weight relative to the other items, due to load order affecting chest loot; Many other issues exist.
Are there alternative designs?
Certainly, but none come to mind and none have yet been proposed.
Porting Notes
This implementation should allow all existing chest loot should retain its current functionality, but it is highly recommended to replace it with code that adds to a loot pool or item pool.
The included mod file can be used to view loot pools, though it may display some chances incorrectly
ItemSourceHelper.zip