Finish implementing deleting unloaded tiles feature, add VanillaFallbackOnModDeletion examples #4325
Conversation
…nModDeletion usage
|
Removing items from storages would be a good option to provide, but isn't needed in the initial implementation. Items are much easier for the player to manage themselves. |
|
As far as modded chest to regular chest goes, An alternative question is if the VanillaFallback type needs to default that modded chests fallback to wooden chests? |
|
We could do wooden chests specifically, or try to have all tiles default to style 0, but that might be hard to implement. The fallback feature is a really rare situation and I don't want every mod with content thinking they need to spend multiple lines declaring a fallback tile and tile style for all modtile. I think keeping it simple is fine, if someone ends up with a locked golden chest, I think that might be better than a selection of different chest style all turning into the same wooden chest. That said, most mods don't even use tile styles so most will be wooden chests anyway. |
When a user decides to disable a mod, that mod will leave unloaded tiles in the world. If the user wishes to permanently remove a mod, then the tiles are a nuisance. The code exists to do this, replacing those tiles with
VanillaFallbackOnModDeletion, but the code currently will not run because it is not hooked up to any UI for the user to click.This PR also will add proper
VanillaFallbackOnModDeletionusage and also update the documentation to warn about how to correctly useVanillaFallbackOnModDeletion.TODO:
Example
In this example several tiles are replaced with suitable alternatives via
VanillaFallbackOnModDeletionusage. ExampleTorch (bottom middle, near the player) shows the default behavior of turning back to dirt. ExampleWallAdvanced shows the default wall behavior, turning to air. ExampleChair, Chest, Block, Sign, Platform, Ore, Bar all revert to a vanilla tile in this example. On the left is TileObjectDataShowcase, which uses different FrameX and FrameY values from a normal 2x2 tile. This shows how a modded might make a mistake if they useVanillaFallbackOnModDeletionon atileframeimportanttile that does not exactly match the layout of the vanilla tile they intend to fallback to.Before:
Unloaded:
Deleted and replaced:
