Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] FormLoginAuthenticator: fail for non-string password #51445

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[Security] FormLoginAuthenticator: fail for non-string password #51445

merged 1 commit into from
Aug 23, 2023

Conversation

dmaicher
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51441
License MIT
Doc PR -

Fixes #51441 by handling it similar to the username and throwing a BadRequestHttpException.

@dmaicher dmaicher requested a review from chalasr as a code owner August 21, 2023 17:19
@carsonbot carsonbot added this to the 5.4 milestone Aug 21, 2023
@nicolas-grekas
Copy link
Member

Thank you @dmaicher.

@nicolas-grekas nicolas-grekas merged commit 6b34c00 into symfony:5.4 Aug 23, 2023
8 of 9 checks passed
@dmaicher dmaicher deleted the issue-51441 branch August 23, 2023 12:22
This was referenced Aug 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@mtarld mtarld mtarld approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@dmaicher @nicolas-grekas @derrabus @mtarld @carsonbot