Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support portrait orientation preview for EXIF image #1412

Merged
merged 2 commits into from
Aug 5, 2024
Merged

feat: add support portrait orientation preview for EXIF image #1412

merged 2 commits into from
Aug 5, 2024

Conversation

TobisLee
Copy link
Contributor

@TobisLee TobisLee commented Aug 4, 2024

#1411

Tested with cr2, nef, arw images

screenshot_20240804_222125

@sxyazi
Copy link
Owner

sxyazi commented Aug 5, 2024

Thanks for the PR!

Could you upload an image that needs orientation for testing?

@TobisLee
Copy link
Contributor Author

TobisLee commented Aug 5, 2024

Sure. Can I upload the image to the assets folder, or where should I upload it?

@TobisLee
Copy link
Contributor Author

TobisLee commented Aug 5, 2024

I can't upload the image to this comment due to the image size. I attempted to upload the image to the assets folder, but to keep the yazi project clean, I decided to upload some sample images to my project (sorry for the messy force-push). You can download them at:https://github.com/TobisLee/sample-portrait-images/blob/main/_Z302267.NEF

Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sxyazi sxyazi merged commit cda7d3f into sxyazi:main Aug 5, 2024
6 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants