try to fix windows tests #1419
try to fix windows tests #1419
Conversation
|
|
|
Can you please change this into a draft PR so I can know when the task is done? |
Sure. Could you take a look at the |
|
@JakubKoralewski I think it's a bug of swc and it will be fixed by #1382 |
|
On further inspection it looks like in the is actually correct, it's just that the way the tests compare the outputs does not take into account Windows paths. I'm not sure if the verbatim @kdy1 What do you think? My idea is that it's an issue with tests not with the current implementation, so I believe it is ready for your review. Considering there is no CI for Windows I don't think modifying the tests logic for a single incorrect test is worth it, I'd add it as a bug and move on. |
I agree. I'll take a look after taking some rest. |
| @@ -1,4 1,5 @@ | |||
| #![cfg_attr(test, feature(test))] | |||
| #![feature(or_patterns)] | |||
There was a problem hiding this comment.
swc uses nightly for a while because of some rustfmt options, but it does not rely on nightly features from non-test codes.
There was a problem hiding this comment.
not required, I just noticed that nightly was used anyway so I wanted to use some terser syntax, i'm not familiar with the consequences of using nightly features. looking at rust-lang/rust/issues/54883 looks to be out in next stable
should I remove it?
There was a problem hiding this comment.
It's okay if it's going to be stabilized. Thanks!
JakubKoralewski
changed the title
Fixes #1417
I had to remove all files and git reset for the changes to show
https://gist.github.com/JakubKoralewski/f6368a554073f14240184b40fefde888
I'd appreciate some help, as I don't know what to do with the above test failures (fixture::pass::issue_1139\example_1 doesnt seem to be path related, but fixture::pass::pr_1105\example_7 seems to be :confused:)