fix(es/minifier): Fix comparison of -0.0 (#9012)

**Related issue:** - Closes #9007
swc-project · Jun 2, 2024 · 8a29577 · 8a29577
1 parent d44ec65
commit 8a29577
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/crates/swc_ecma_minifier/src/compress/util/mod.rs b/crates/swc_ecma_minifier/src/compress/util/mod.rs
@@ -760,12  760,12 @@ impl Visit for SuperFinder {
 }
 
 fn cmp_num(a: f64, b: f64) -> Ordering {
-    if a == -0.0 && b == 0.0 {
-        return Ordering::Greater;
     if a == 0.0 && a.is_sign_negative() && b == 0.0 && b.is_sign_positive() {
         return Ordering::Less;
     }
 
-    if a == 0.0 && b == -0.0 {
-        return Ordering::Less;
     if a == 0.0 && a.is_sign_positive() && b == 0.0 && b.is_sign_negative() {
         return Ordering::Greater;
     }
 
     a.partial_cmp(&b).unwrap()

diff --git a/crates/swc_ecma_minifier/tests/fixture/issues/9007/input.js b/crates/swc_ecma_minifier/tests/fixture/issues/9007/input.js
@@ -0,0  1,4 @@
 console.log(Math.min(-0, 0))
 console.log(Math.min(0, -0))
 console.log(Math.max(-0, 0))
 console.log(Math.max(0, -0))
diff --git a/crates/swc_ecma_minifier/tests/fixture/issues/9007/output.js b/crates/swc_ecma_minifier/tests/fixture/issues/9007/output.js
@@ -0,0  1 @@
 console.log(-0), console.log(-0), console.log(0), console.log(0);