Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently not working on arm64, but easy to workaround/fix #189

Open
iCrawl opened this issue Jan 9, 2023 · 2 comments
Open

Currently not working on arm64, but easy to workaround/fix #189

iCrawl opened this issue Jan 9, 2023 · 2 comments
Assignees
@kwonoj

Comments

@iCrawl
Copy link

iCrawl commented Jan 9, 2023

https://www.npmjs.com/package/bin-wrapper uses an outdated library called https://www.npmjs.com/package/os-filter-obj which doesn't support non-Intel arch: kevva/os-filter-obj#3

This makes swcx currently not work via this wrapper.

cli/src/swcx/index.ts

Line 131 in df9b9ec

.src(`${releaseBase}/${binaryName}`, platform, arch)

Removing platform and arch here, makes it work fine and should also cause no problems since with the getBinaryName() function we already download the correct platform and arch from the releases page.

cli/src/swcx/index.ts

Line 101 in df9b9ec

arm64: "swc-darwin-arm64",

cli/src/swcx/index.ts

Line 110 in df9b9ec

const binaryName = platformBinaryMap[platform][arch];

@wesbos
Copy link

wesbos commented Jan 12, 2023

Also not able to use the CLI at all. npx swc or npm i -g swc on a Macbook M1

@kwonoj
Copy link
Member

kwonoj commented Jan 12, 2023

I did add platform / arch explicitly to workaround some issue, problem is I do not remember what the problem was. :/

@wesbos this issue is not related with those, and the pkg name for the swc cli is @swc/cli, not swc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwonoj kwonoj

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wesbos @kwonoj @iCrawl