Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: generate blog RSS feed with full content rather than a description #9085

Open
wants to merge 2 commits into
base: svelte-4
Choose a base branch
from
Open

site: generate blog RSS feed with full content rather than a description #9085

wants to merge 2 commits into from

Conversation

martgnz
Copy link

@martgnz martgnz commented Aug 9, 2023 •
edited
Loading

In the Svelte blog, only a short description is being generated for each post. This PR changes that to use the full content instead. This has a few benefits including letting people read the blog post offline (imagine you have a spotty connection or are traveling) and it also avoids a browser click. This PR also adds author information to the feed.

I've tested locally on NetNewsWire and it works well with a localhost feed.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5c8d3e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@martgnz martgnz marked this pull request as draft August 9, 2023 01:28
@martgnz martgnz marked this pull request as ready for review August 9, 2023 01:55
@benmccann benmccann changed the title feat: Generate blog RSS feed with full content rather than a description site: generate blog RSS feed with full content rather than a description Sep 21, 2023
@sebastiandedeyne sebastiandedeyne mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martgnz @benmccann