Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @html mismatch in hydration #9063

Draft
wants to merge 2 commits into
base: svelte-4
Choose a base branch
from
Draft

Conversation

gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Aug 2, 2023

fixes #9057
fixes #8213

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

⚠️ No Changeset found

Latest commit: 1b62914

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brunnerh
Copy link
Member

brunnerh commented Aug 2, 2023

Contains changes to playground, maybe not intended?

@gtm-nayan
Copy link
Contributor Author

Yeah, still have to write tests and clean things up, thanks for the heads up.

@Crenshinibon
Copy link

Any progress here? I would like to avoid transforming all @html uses with the action/innerHTML-Workaround.

@kelvinsjk
Copy link
Contributor

Have copied this PR locally and it seems to fix #7653 as well

@elron
Copy link

elron commented Dec 13, 2023

When this fix is going to be pushed?

@willhoup
Copy link

willhoup commented Feb 1, 2024

Curious about the state of this work as well. We are running into similar issues outlined in the linked issues from the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR hydration bug with @html and localStorage {@html} tag is broken during hydration
7 participants