Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip is_standalone optimisation for dynamic components #12767

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #12677. <Foo.Bar> should be treated as a dynamic component and should not have the is_standalone optimisation that allows sole children of blocks to append directly to the current fragment

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: ab1f6ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm trueadm merged commit ec8a029 into main Aug 8, 2024
9 checks passed
@trueadm trueadm deleted the gh-12677 branch August 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0.0-next.203: TypeError: null is not an object (evaluating 'item.next.e.nodes.start')
2 participants