Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more efficient hydration markers #11019

Merged
merged 4 commits into from
Apr 1, 2024
Merged

feat: more efficient hydration markers #11019

merged 4 commits into from
Apr 1, 2024

Conversation

Rich-Harris
Copy link
Member

Currently, if and each blocks insert additional hydration markers to allow graceful recovery in the case of an SSR/CSR mismatch. These markers are removed from the DOM during hydration.

We can simplify things by encoding this information in the closing hydration marker. That way, no removal is necessary — we just inspect anchor.data. As a bonus, the SSR'd HTML is shorter.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9700ee5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

What exactly is the encoding? The ! ? This should be commented somewhere else it's easy to overlook / harder to understand why it's added.

@Rich-Harris
Copy link
Member Author

fair point — pushed a commit

@Rich-Harris Rich-Harris merged commit 0a16292 into main Apr 1, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the hydration-else branch April 1, 2024 22:03
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @dummdidumm