Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG baseVal #1528

Open
Rich-Harris opened this issue Jun 6, 2018 · 5 comments
Open

SVG baseVal #1528

Rich-Harris opened this issue Jun 6, 2018 · 5 comments
Labels
compiler Changes relating to the compiler feature request perf stale-bot temp-stale
Milestone
5.x

Comments

@Rich-Harris
Copy link
Member

It turns out that this...

rect.x.baseVal.value = 200;

...is faster than this:

rect.setAttribute('x', 200);

This might be something we can use to our benefit.
@Rich-Harris
Copy link
Member Author

It might improve the performance of http://rethinking-reactivity.surge.sh/svelte-svg/, which would be fun

@NazimHAli
Copy link

NazimHAli commented Aug 16, 2020 •
edited
Loading

Is anyone working on this? I can pick it up if not.

@antony
Copy link
Member

antony commented Aug 16, 2020

@NazimAli2017 I doubt very much anyone is working on this - it's more than 2 years old with no comments. We'd welcome your contributions :)

@NazimHAli
Copy link

@antony awesome, going to start on this! Will do some research to setup a baseline/benchmark for comparison 🎉

@pngwn pngwn added compiler Changes relating to the compiler temp-stale and removed internals labels Jun 26, 2021
@stale
Copy link

stale bot commented Dec 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Dec 26, 2021
@Rich-Harris Rich-Harris added this to the 5.x milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler Changes relating to the compiler feature request perf stale-bot temp-stale
Projects
None yet
Milestone
5.x
Development

No branches or pull requests
5 participants
@antony @Rich-Harris @pngwn @Conduitry @NazimHAli