[Infrastructure] Fix widget tester tapping on block component (Resolves #2197) #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
|
|
||
| // Translate the rect to global coordinates. | ||
| final documentLayoutElement = _findDocumentLayoutElement(superEditorFinder); |
There was a problem hiding this comment.
I'm thinking that the need to access the document element isn't great. Does the DocumentLayout interface not offer any way to accomplish this goal as-is?
There was a problem hiding this comment.
I didn't find any method to allow that. The Rect returned by Component.getEdgeForPosition is in component space and I didn't find any other method to convert it to document space.
|
@matthew-carroll I search on the current main but I didn't find any tests like the one posted in the issue ticket, where we manually place the selection using Should I include that test? |
matthew-carroll
approved these changes
Aug 10, 2024
matthew-carroll
pushed a commit
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Infrastructure] Fix widget tester tapping on block component. Resolves #2197
Trying to tap on the downstream position of a block component is always resulting in an upstream selection.
The issue is that the computation to determine the offset to tap relies on
getRectForPosition. For block components, this always return a rect of the entire component, as is documented in the method:This PR changes the
tapAtDocumentPositionto handle block components differently, by computing its edge position and returning aRectof half of the component's width.