Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v2.39.2 and above break types #974

Closed
2 tasks done
sg3510 opened this issue Feb 13, 2024 · 6 comments · Fixed by #975
Closed
2 tasks done

Version v2.39.2 and above break types #974

sg3510 opened this issue Feb 13, 2024 · 6 comments · Fixed by #975
Labels
bug Something isn't working

Comments

@sg3510
Copy link

sg3510 commented Feb 13, 2024

Likely because of bumping postgrest-js with v2.39.2 but when using strict in tsconfig and any code like this:

const { error } = await supabase
      .from("Messages")
      .update({ deletedAt: moment().toISOString()})

gives me Argument of type "{ deletedAt: string; }" is not assignable to parameter of type "never".

I have confirmed I have the latest generated types.

Bug report

-->

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

See above

To Reproduce

Upgrade to v2.39.2 or above

Expected behavior

TS linter shouldn"t complain

System information

  • OS: [e.g. macOS, Windows]
  • Browser (if applies) [e.g. chrome, safari]
  • Version of supabase-js: [e.g. 2.39.2]

Additional context

Add any other context about the problem here.

@sg3510 sg3510 added the bug Something isn't working label Feb 13, 2024
@pierre-charpentier
Copy link

Faced this issue in version v2.39.4 but not in v2.39.3.

With git bisect, I tracked down the issue to this commit : a5a70db

It seems some types are not infered properly anymore.

@heloineto
Copy link

Having the same issue

@Gbuomprisco
Copy link

Faced this issue in version v2.39.4 but not in v2.39.3.

With git bisect, I tracked down the issue to this commit : a5a70db

It seems some types are not infered properly anymore.

Same here - I reverted to 2.39.3 and all good.

@kstolk
Copy link

kstolk commented Apr 19, 2024

Still an issue, any updates?

@rnnc
Copy link

rnnc commented Jul 18, 2024

still an issue

1 similar comment
@theshadowagent
Copy link

still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants