Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Migrate dashboard from auth0 to gotrue #4339

Merged
merged 20 commits into from
Dec 17, 2021
Merged

Fix: Migrate dashboard from auth0 to gotrue #4339

merged 20 commits into from
Dec 17, 2021

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Dec 6, 2021 •
edited
Loading

What kind of change does this PR introduce?

  • (finally) start using gotrue for authenticating supabase users

Steps

  1. IYKYK run api server
  2. Set the following in your .env
NEXT_PUBLIC_GOTRUE_ENABLED=true
NEXT_PUBLIC_GOTRUE_URL="http://localhost:8000/auth/v1"
NEXT_PUBLIC_SITE_URL="http://localhost:8082"
  1. cd studio && npm install && npm run dev

Issues

  • Small issue with the user not being logged in immediately after being redirected to the dashboard (to get around this, just refresh the page after being redirected) SOLVED

@kangmingtay kangmingtay self-assigned this Dec 6, 2021
@vercel
Copy link

vercel bot commented Dec 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

about – ./about

🔍 Inspect: https://vercel.com/supabase/about/DkjQMYyvfJMaDFqQipgNeb9McC1H
✅ Preview: Canceled

[Deployment for 069102b canceled]

zones-docs – ./web

🔍 Inspect: https://vercel.com/supabase/zones-docs/ESRsRZjD8xNFdvBua18azyTPXAir
✅ Preview: https://zones-docs-git-km-migrate-to-gotrue-supabase.vercel.app

[Deployment for 069102b canceled]

zone-www-dot-com – ./www

🔍 Inspect: https://vercel.com/supabase/zone-www-dot-com/2Xgw9Fi5HumL1PRQXrVKFhwKLyhR
✅ Preview: https://zone-www-dot-com-git-km-migrate-to-gotrue-supabase.vercel.app

[Deployment for 069102b canceled]

phamhieu
phamhieu requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@phamhieu phamhieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't login with Github. After redirecting to homepage, it's unauthorised.

Do i need special version of api? I'm using the latest on develop branch

studio/components/layouts/AccountLayout/AccountLayout.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – zones-docs December 7, 2021 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 7, 2021 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 7, 2021 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 9, 2021 00:23 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs December 9, 2021 00:23 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 9, 2021 00:23 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 9, 2021 04:59 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 9, 2021 04:59 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs December 9, 2021 04:59 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 9, 2021 06:44 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs December 9, 2021 06:44 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 9, 2021 06:44 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs December 9, 2021 09:06 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 9, 2021 09:06 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 9, 2021 09:06 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 14, 2021 08:54 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 14, 2021 09:00 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 14, 2021 13:18 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 14, 2021 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs December 14, 2021 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 16, 2021 10:39 Inactive
@vercel vercel bot temporarily deployed to Preview – about December 16, 2021 13:47 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 16, 2021 13:47 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs December 16, 2021 13:47 Inactive
@kangmingtay kangmingtay merged commit 73ca8e8 into master Dec 17, 2021
@kangmingtay kangmingtay deleted the km/migrate-to-gotrue branch December 17, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamhieu phamhieu phamhieu approved these changes

@awalias awalias Awaiting requested review from awalias

@inian inian Awaiting requested review from inian

@kiwicopple kiwicopple Awaiting requested review from kiwicopple

@joshenlim joshenlim Awaiting requested review from joshenlim

Assignees

@kangmingtay kangmingtay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangmingtay @phamhieu @joshenlim