Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nulls last when sorting users #30430

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

alaister
Copy link
Member

@alaister alaister commented Nov 12, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When sorting on last sign in at descending, you have to scroll past a bunch of users that haven't ever signed in before you can see your most recent sign in

What is the new behavior?

Moves these users to the end

Additional context

Before:
Screenshot 2024-11-12 at 16 13 01

@alaister alaister requested a review from a team as a code owner November 12, 2024 08:14
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:20am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Nov 12, 2024 8:20am
studio ⬜️ Ignored (Inspect) Nov 12, 2024 8:20am
studio-self-hosted ⬜️ Ignored (Inspect) Nov 12, 2024 8:20am
docs ⬜️ Skipped (Inspect) Nov 12, 2024 8:20am
zone-www-dot-com ⬜️ Skipped (Inspect) Nov 12, 2024 8:20am

Copy link

supabase bot commented Nov 12, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified that null values are shifted to the bottom when sorted

@alaister alaister merged commit eb7b081 into master Nov 12, 2024
16 checks passed
@alaister alaister deleted the fix/users-sort-nulls-last branch November 12, 2024 09:50
zackproser-workos pushed a commit to zackproser-workos/supabase that referenced this pull request Nov 13, 2024
encima pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants