fix(docs): ref scroll #29819
Merged
fix(docs): ref scroll #29819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes detected in Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
25fa8e3
to
8802fcf
Compare
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
8802fcf
to
f1c23a9
Compare
Fix various scrolling bugs with reference pages: - Take out smooth scrolling as it tends to lead to buggy scrolling position - Add overscroll-behavior: contain to the nav, otherwise overscrolling on the nav scrolls the main page, which causes the nav to jump around unexpectedly - Put aria-current calculation in useEffect as otherwise it doesn't trigger properly on first load
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
f1c23a9
to
49fe084
Compare
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
49fe084
to
86aedd0
Compare
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
86aedd0
to
85bb2b5
Compare
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
85bb2b5
to
4f0e4e6
Compare
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
4f0e4e6
to
1b9b9d6
Compare
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
1b9b9d6
to
f621542
Compare
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
f621542
to
47dbdb0
Compare
avallete
approved these changes
Oct 11, 2024
| const scrollPosition = offsetTop - parentOffsetTop | ||
|
|
||
| parentRef.current?.scrollTo({ | ||
| top: scrollPosition - 60 /* arbitrary padding */, |
There was a problem hiding this comment.
question
If that's meant to offset the scrolling, doesn't that match the "top navbar" height (50px) a bit of padding ?
There was a problem hiding this comment.
yep that's true, will update comment 👍🏼
fsansalvadore
approved these changes
Oct 11, 2024
charislam
force-pushed
the
fix/ref-nav-scroll
branch
from
47dbdb0
to
f23a782
Compare
Crispy1975
pushed a commit
that referenced
this pull request
Oct 16, 2024
Fix various scrolling bugs with reference pages: - Take out smooth scrolling as it tends to lead to buggy scrolling position - Add overscroll-behavior: contain to the nav, otherwise overscrolling on the nav scrolls the main page, which causes the nav to jump around unexpectedly - Put aria-current calculation in useEffect as otherwise it doesn't trigger properly on first load
encima
pushed a commit
that referenced
this pull request
Nov 19, 2024
Fix various scrolling bugs with reference pages: - Take out smooth scrolling as it tends to lead to buggy scrolling position - Add overscroll-behavior: contain to the nav, otherwise overscrolling on the nav scrolls the main page, which causes the nav to jump around unexpectedly - Put aria-current calculation in useEffect as otherwise it doesn't trigger properly on first load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various scrolling bugs with reference pages:
See https://supabase.slack.com/archives/C023E4L60R3/p1728116359237709