Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set schema dropdown if a table is selected #28560

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

saltcod
Copy link
Contributor

@saltcod saltcod commented Aug 12, 2024

Sets the right selectedSchema in the dropdown if we go directly to a table

To reproduce:

  • in the Table Editor, select Realtime from the schema selector dropdown, then select a table https://share.cleanshot.com/FZ3KfvfD
  • refresh the page (or grab the url, open a new tab and open that table in a new tab)
  • see that public is set as the selected schema again

@saltcod saltcod requested a review from a team as a code owner August 12, 2024 16:30
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 4:39pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 4:39pm
studio ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 4:39pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 4:39pm
docs ⬜️ Skipped (Inspect) Aug 12, 2024 4:39pm
zone-www-dot-com ⬜️ Skipped (Inspect) Aug 12, 2024 4:39pm

Copy link

supabase bot commented Aug 12, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

@@ -90,17 91,28 @@ const TableEditorMenu = () => {
const schema = schemas?.find((schema) => schema.name === snap.selectedSchemaName)
const canCreateTables = useCheckPermissions(PermissionAction.TENANT_SQL_ADMIN_WRITE, 'tables')

const refreshTables = async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it's been unused for a while

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested as described

@saltcod saltcod merged commit cef9c2f into master Aug 12, 2024
14 checks passed
@saltcod saltcod deleted the chore/set-schema-dropdown branch August 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants