test: perf with simpler crawler pages

supabase · charislam · Aug 13, 2024 · Jul 4, 2024 · Jul 4, 2024 · Jul 5, 2024
commit 782c9a62cc3868681bd7fc0eef59698a08f635a5
diff --git a/apps/docs/app/reference/[...slug]/page.tsx b/apps/docs/app/reference/[...slug]/page.tsx
@@ -34,11  34,7 @@ export default async function ReferencePage({
     return (
       <ClientSdkReferencePage
         sdkId={sdkId}
-        libId={sdkData.meta[version].libId}
-        libPath={sdkData.libPath}
         libVersion={maybeVersion ?? latestVersion}
-        specFile={sdkData.meta[version].specFile}
-        useTypeSpec={sdkData.typeSpec ?? false}
         isCrawlerPage={!!maybeCrawlers}
         requestedSection={path[0]}
       />

diff --git a/apps/docs/features/docs/Reference.sdkPage.tsx b/apps/docs/features/docs/Reference.sdkPage.tsx
@@ -1,11  1,12 @@
 import { MenuId } from '~/components/Navigation/NavigationMenu/NavigationMenu'
 import * as NavItems from '~/components/Navigation/NavigationMenu/NavigationMenu.constants'
 import { REFERENCES } from '~/content/navigation.references'
 import { getFlattenedSections } from '~/features/docs/Reference.generated.singleton'
 import { ClientLibHeader } from '~/features/docs/Reference.header'
 import { ClientLibIntroduction, OldVersionAlert } from '~/features/docs/Reference.introduction'
 import { ClientSdkNavigation } from '~/features/docs/Reference.navigation'
 import { ReferenceContentScrollHandler } from '~/features/docs/Reference.navigation.client'
-import { ClientLibRefSections } from '~/features/docs/Reference.sections'
 import { ClientLibRefSections, SectionSwitch } from '~/features/docs/Reference.sections'
 import { LayoutMainContent } from '~/layouts/DefaultLayout'
 import { SidebarSkeleton } from '~/layouts/MainSkeleton'
 
@@ -17,15  18,7 @@ type ClientSdkReferenceProps = {
   | { isCrawlerPage: true; requestedSection: string }
 )
 
-const _clientSdkComponentCache = new Map<string, any>()
-export async function ClientSdkReferencePage(props) {
-  const key = JSON.stringify(props)
-  if (!_clientSdkComponentCache.has(key)) {
-    _clientSdkComponentCache.set(key, ClientSdkReferencePageUncached(props))
-  }
-  return _clientSdkComponentCache.get(key)
-}
-async function ClientSdkReferencePageUncached({
 export async function ClientSdkReferencePage({
   sdkId,
   libVersion,
   isCrawlerPage = false,
@@ -37,6  30,14 @@ async function ClientSdkReferencePageUncached({
 
   const menuData = NavItems[libraryMeta.meta[libVersion].libId]
 
   if (isCrawlerPage) {
     const sections = await getFlattenedSections(sdkId, libVersion)
     const section = sections.find((section) => section.slug === requestedSection)
     if (!section) return null
 
     return <SectionSwitch sdkId={sdkId} version={libVersion} section={section} isCrawlerPage />
   }
 
   return (
     <ReferenceContentScrollHandler libPath={libraryMeta.libPath}>
       <SidebarSkeleton
@@ -72,17  73,7 @@ async function ClientSdkReferencePageUncached({
                 />
               </>
             )}
-            <ClientLibRefSections
-              sdkId={sdkId}
-              libPath={libraryMeta.libPath}
-              version={libVersion}
-              isLatestVersion={isLatestVersion}
-              specFile={libraryMeta.meta[libVersion].specFile}
-              useTypeSpec={libraryMeta.typeSpec}
-              {...(isCrawlerPage
-                ? { isCrawlerPage: true, requestedSection }
-                : { isCrawlerPage: false })}
-            />
             <ClientLibRefSections sdkId={sdkId} version={libVersion} />
           </article>
         </LayoutMainContent>
       </SidebarSkeleton>

diff --git a/apps/docs/features/docs/Reference.sections.tsx b/apps/docs/features/docs/Reference.sections.tsx
@@ -2,6  2,7 @@ import { Fragment } from 'react'
 
 import { Tabs_Shadcn_, TabsContent_Shadcn_, TabsList_Shadcn_, TabsTrigger_Shadcn_, cn } from 'ui'
 
 import { REFERENCES } from '~/content/navigation.references'
 import { getRefMarkdown, MDXRemoteRefs } from '~/features/docs/Reference.mdx'
 import { MDXProviderReference } from '~/features/docs/Reference.mdx.client'
 import type { MethodTypes } from '~/features/docs/Reference.typeSpec'
@@ -22,67  23,27 @@ import { normalizeMarkdown } from '~/features/docs/Reference.utils'
 
 type ClientLibRefSectionsProps = {
   sdkId: string
-  libPath: string
   version: string
-  isLatestVersion: boolean
-  specFile: string
-  useTypeSpec: boolean
 } & (
   | { isCrawlerPage?: false; requestedSection?: undefined }
   | { isCrawlerPage: true; requestedSection: string }
 )
 
-async function ClientLibRefSections({
-  sdkId,
-  libPath,
-  version,
-  isLatestVersion,
-  specFile,
-  useTypeSpec,
-  isCrawlerPage = false,
-  requestedSection,
-}: ClientLibRefSectionsProps) {
 async function ClientLibRefSections({ sdkId, version }: ClientLibRefSectionsProps) {
   const flattenedSections = await getFlattenedSections(sdkId, version)
-
-  let requestedSectionMeta: AbbrevCommonClientLibSection
-  if (isCrawlerPage) {
-    requestedSectionMeta = flattenedSections.find((section) => section.slug === requestedSection)
-  } else {
-    trimIntro(flattenedSections)
-  }
   trimIntro(flattenedSections)
 
   return (
     <MDXProviderReference>
       <div className="flex flex-col my-16 gap-16">
-        {isCrawlerPage
-          ? !!requestedSectionMeta && (
-              <SectionSwitch
-                sdkId={sdkId}
-                libPath={libPath}
-                version={version}
-                isLatestVersion={isLatestVersion}
-                section={requestedSectionMeta}
-                specFile={specFile}
-                useTypeSpec={useTypeSpec}
-                isCrawlerPage
-              />
-            )
-          : flattenedSections
-              .filter((section) => section.type !== 'category')
-              .map((section, idx) => (
-                <Fragment key={`${section.id}-${idx}`}>
-                  <SectionDivider />
-                  <SectionSwitch
-                    sdkId={sdkId}
-                    libPath={libPath}
-                    version={version}
-                    isLatestVersion={isLatestVersion}
-                    section={section}
-                    specFile={specFile}
-                    useTypeSpec={useTypeSpec}
-                  />
-                </Fragment>
-              ))}
         {flattenedSections
           .filter((section) => section.type !== 'category')
           .map((section, idx) => (
             <Fragment key={`${section.id}-${idx}`}>
               <SectionDivider />
               <SectionSwitch sdkId={sdkId} version={version} section={section} />
             </Fragment>
           ))}
       </div>
     </MDXProviderReference>
   )
@@ -99,27  60,17 @@ function SectionDivider() {
   return <hr />
 }
 
-interface SectionSwitchProps {
 type SectionSwitchProps = {
   sdkId: string
-  libPath: string
   version: string
-  isLatestVersion: boolean
   section: AbbrevCommonClientLibSection
-  specFile: string
-  useTypeSpec: boolean
   isCrawlerPage?: boolean
 }
 
-function SectionSwitch({
-  sdkId,
-  libPath,
-  section,
-  version,
-  isLatestVersion,
-  specFile,
-  useTypeSpec,
-  isCrawlerPage,
-}: SectionSwitchProps) {
 export function SectionSwitch({ sdkId, version, section, isCrawlerPage }: SectionSwitchProps) {
   const libPath = REFERENCES[sdkId].libPath
   const isLatestVersion = version === REFERENCES[sdkId].versions[0]
 
   const sectionLink = `/docs/reference/${libPath}/${isLatestVersion ? '' : `${version}/`}${section.slug}`
 
   switch (section.type) {
@@ -141,7  92,7 @@ function SectionSwitch({
           version={version}
           link={sectionLink}
           section={section}
-          useTypeSpec={useTypeSpec}
           useTypeSpec={REFERENCES[sdkId].typeSpec}
           isCrawlerPage={isCrawlerPage}
         />
       )