Refactor/app router refs #28095
Merged
Refactor/app router refs #28095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes detected in Branching Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
charislam
force-pushed
the
refactor/app-router-refs
branch
from
821b3c0
to
f5cb763
Compare
charislam
force-pushed
the
refactor/app-router-refs
branch
from
afb6d9a
to
1a19f0f
Compare
charislam
force-pushed
the
refactor/app-router-refs
branch
from
1a19f0f
to
cea79a3
Compare
charislam
force-pushed
the
refactor/app-router-refs
branch
from
2b78819
to
c9fdc69
Compare
charislam
force-pushed
the
refactor/app-router-refs
branch
from
3581c11
to
ac2dafa
Compare
charislam
force-pushed
the
refactor/app-router-refs
branch
from
74cde5b
to
b1eaa9b
Compare
charislam
force-pushed
the
refactor/app-router-refs
branch
from
aba2762
to
6252cf5
Compare
charislam
force-pushed
the
refactor/app-router-refs
branch
from
6252cf5
to
761d1d6
Compare
saltcod
reviewed
Aug 13, 2024
| @@ -0,0 1,72 @@ | |||
| import { load } from 'cheerio' | |||
|
a lot happening here but seems to do as described! :^) |
saltcod
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates client SDK References to App Router. (Management and CLI API references aren't migrated yet, nor are self-hosting config references.)
Some notes:
Big changes to the way crawler pages are built and individual section URLs (e.g.,
javascript/select) are served. All of these used to be SSG-generated pages, but the number of heavy pages was just too much to handle -- slow as molasses and my laptop sounded like it was taking off, and CI sometimes refuses to build it all at all.Tried various tricks with caching and pre-generating data but no dice.
So I changed to only building one copy of each SDK version page, then serving the sub-URLs through a response rewrite. That's for the actual user-visible pages.
For the bot pages, each sub-URL needs to be its own page, but prebuilding it doesn't work, and rendering on demand from React components is too slow (looking for super-fast response here for SEO). Instead I changed to using an API route that serves very minimal, hand-crafted HTML. It looks ugly, but it's purely for the search bots.
You can test what bots see by running
curl --user-agent "Mozilla/5.0 (iPhone; CPU iPhone OS 6_0 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Version/6.0 Mobile/10A5376e Safari/8536.25 (compatible; Googlebot/2.1; http://www.google.com/bot.html)" <URL_OF_PAGE>Also added some smoke tests to run against prod for the crawler routes, since we don't keep an eye on those regularly, and Vercel config changes could surprise-break them. Tested the meta images on Open Graph and all seems to work fine.
With this approach, full production builds are really fast: ~5 minutes
Starts using the new type spec handling, which is better at finding params automatically, so I could remove some of the manually written ones from the spec files.