Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add placeholder in database functions editor #27922

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Add placeholder in database functions editor #27922

merged 6 commits into from
Jul 15, 2024

Conversation

joshenlim
Copy link
Member

No description provided.

@joshenlim joshenlim requested a review from a team as a code owner July 11, 2024 08:39
@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 5:42am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 5:42am
docs ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 5:42am
studio ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 5:42am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 5:42am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 5:42am

@supabase Supabase
Copy link

supabase bot commented Jul 11, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

@joshenlim joshenlim requested a review from ivasilov July 11, 2024 10:04
alaister
alaister reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bug spotted:
Screenshot 2024-07-12 at 11 31 42

Additionally I think we should only show this placeholder for plpgsql functions (sql functions don't use it)

@joshenlim
Copy link
Member Author

Additionally I think we should only show this placeholder for plpgsql functions (sql functions don't use it)

Good point! pushed a fix for this

Small bug spotted:

Can I check how you ran into this? I can't seem to reproduce this

@joshenlim joshenlim requested a review from alaister July 12, 2024 09:04
@ivasilov
Copy link
Member

ivasilov commented Jul 12, 2024 •
edited
Loading

The placeholder only shows up for me on second opening of the sheet.
Video

The placeholder is also shown when editing an existing function (authorize function from the Slack Clone example)
Screenshot 2024-07-12 at 13 46 06

alaister
alaister approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested creating and saving a new function
  • Tested editing existing functions (sql, plpgsql)

@joshenlim joshenlim merged commit 2662583 into master Jul 15, 2024
14 checks passed
@joshenlim joshenlim deleted the chore/add-placeholder-in-database-functions-editor branch July 15, 2024 06:24
charislam pushed a commit that referenced this pull request Jul 16, 2024
@joshenlim @charislam
Add placeholder in database functions editor (#27922)
3d32225 
* Add placeholder in database functions editor

* Address feedback

* Don't show placeholder if language is sql

* Fixes

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaister alaister alaister approved these changes

@ivasilov ivasilov Awaiting requested review from ivasilov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshenlim @ivasilov @alaister