Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snippet organization in SQL Editor #27881

Merged
merged 43 commits into from
Jul 17, 2024
Merged

Conversation

joshenlim
Copy link
Member

No description provided.

@joshenlim joshenlim requested a review from a team as a code owner July 9, 2024 15:36
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:59am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:59am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:59am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:59am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 8:59am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 8:59am

Copy link

supabase bot commented Jul 9, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

@joshenlim
Copy link
Member Author

Okay just pushed a fix for the issue you reported :)

@joshenlim joshenlim requested a review from alaister July 12, 2024 10:49
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I can't seem to use this button to create a snippet?
Screenshot 2024-07-15 at 14 42 22

Also another thing I did notice is snippets don't seem to auto-rename anymore?

Tested so far:

  • creating a snippet
  • creating a folder
  • moving a snippet from root to a folder
  • moving a snippet back to root
  • moving a snippet from one folder to another

apps/studio/hooks/ui/useFlag.ts Outdated Show resolved Hide resolved
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops accidentally approved before

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Finished testing:

  • creating a snippet inside a folder
  • renaming a snippet inside a folder
  • sharing a snippet in a folder
  • unsharing a snippet
  • opening in a new tab

@joshenlim joshenlim merged commit 17e0c5d into master Jul 17, 2024
15 checks passed
@joshenlim joshenlim deleted the feat/sql-folders-new branch July 17, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants