fix(auth-emails): improve template selection and naming consistency #27759
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@Unique-Usman is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -7,7 7,7 @@ const CONFIRMATION: FormSchema = { | |||
| $schema: JSON_SCHEMA_VERSION, | |||
| id: 'CONFIRMATION', | |||
| type: 'object', | |||
| title: 'Confirm signup', | |||
| title: 'Confirm SignUp', | |||
There was a problem hiding this comment.
Hi @Unique-Usman - thank you the pull request and great work so far well done 👍
Left a few comments for you.
| @@ -157,7 158,7 @@ const UserDropdown = ({ | |||
| }} | |||
| > | |||
| <Mail size={14} /> | |||
| <p>Send magic link</p> | |||
| <p>{isUserConfirmed ? "Send magic link": "Send confirm sign up link"}</p> | |||
There was a problem hiding this comment.
I think the email that gets sent out needs to be different as well as at the moment the same magic link email gets emailed even if the Send confirm sign up link is showing.
There was a problem hiding this comment.
@Hallidayo , thanks for the review, https://github.com/orgs/supabase/discussions/27425 from this issues it state that, it sends the confirmation when the email is not yet confirmed. Also, this is the mutation function sending the email
https://github.com/supabase/supabase/blob/master/apps/studio/components/interfaces/Auth/Users/UserDropdown.tsx#L57 and there not appear which function is sending the confirm sign up.
|
@Hallidayo, bringing your attention to this. |
What kind of change does this PR introduce?
frontend fix
#27475