Feature: Allow copying the table definition from the dropdown menu #27621
Conversation
…niton (functionality unfinished yet)Initial commit
…rom-the-dropdown-menu
…rom-the-dropdown-menu
…-from-the-dropdown-menu
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
@nickterhaar is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -0,0 1,66 @@ | |||
| import { useMemo } from 'react' | |||
There was a problem hiding this comment.
Should be able to use this one instead?
https://github.com/supabase/supabase/blob/master/apps/studio/data/database/table-definition-query.ts
There was a problem hiding this comment.
The useMemo is what was used in the logic I got from the 'TableDefinition.tsx'. But I'll take a look into using the 'table-definition-query.ts'
There was a problem hiding this comment.
Removed the use of useMemo. We still need the rest to have a tableResult or a viewResult. Also the useTableDefinitionQuery returns a not so nice formatted (unnecessary spaces, etc.) , uppercase version of the query, so formatDefinition is still used to make it look as nice as it already was in the definition tab.
| copyDefinition() | ||
| }} | ||
| > | ||
| <IconCopy size="tiny" /> |
There was a problem hiding this comment.
I think let's use https://lucide.dev/icons/files instead?
There was a problem hiding this comment.
I think that icon is usable. I'll change it.
There was a problem hiding this comment.
Changed the icon to IconClipboard.
I've tried the files one from lucide, but it wasn't displaying in the correct color as the other icons. Also, because the function copy's the definition to the clipboard, I thought maybe this one was more suiting. Let me know.
| @@ -29,6 29,8 @@ import { | |||
| import { useProjectContext } from '../ProjectLayout/ProjectContext' | |||
| import { useProjectLintsQuery } from 'data/lint/lint-query' | |||
| import { getEntityLintDetails } from 'components/interfaces/TableGridEditor/TableEntity.utils' | |||
| import useTableDefinition from '../../../hooks/misc/useTableDefinition' | |||
There was a problem hiding this comment.
should be able to import these like this?
There was a problem hiding this comment.
I'll change the import as it is in the given example.
Got mine from somewhere else where it's also done the way I did it, but how it's done in the example is much cleaner.
There was a problem hiding this comment.
Cleaned up the hook imports.
|
Thanks @nickterhaar ! Left a couple of comments |
@saltcod Thanks for the comments. Gonna work on them asap. |
nickterhaar
force-pushed
the
feature/Allow-copying-the-table-definition-from-the-dropdown-menu
branch
from
2603529
to
ae217bb
Compare
|
yeah sure @nickterhaar making the dropdowns consistent would be great. |
Alright! I will start working on that soon and will create a new PR for that. Is there anything else that I can do for this PR? If so, let me know and I will do that first. |
|
@nickterhaar any idea what happened with all the file changes? There's 120 file changes in this PR now 😬 |
@saltcod I merged master with my branch and suddenly had 'some' extra files. My mistake. |
|
@nickterhaar |
This reverts commit ffc1138.
|
@saltcod I've reverted the merge with master commit, changed the icon in |
|
See #27900 for the same functionality on the Database page. |
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Feature
What is the current behavior?
#27538
We can now get the table definition from here
Would be great if we could copy it from here ("Copy table definition")
What is the new behavior?
Now in the 'Table Editor', when opening the menu of one of the tables, you'll get the option to 'Copy Definition' (see screenshot).
Additional context
I've used the same 'copy' icon as which is being used for 'Duplicate Table'. Because of this, I've put the 'Copy Definition' at the bottom of the list. Let me know if I need to use a different icon for this.
I've also created a 'useTableDefinition' hook, the logic of this hook was found in the 'TableDefinition.tsx' component. Because I had to reuse this logic, I thought it would be a better idea to write one new hook and let the existing component and my new feature make use of it, instead of reusing/copying the same code. Please let me know is this is okay or if I need to do it differently.
Add any other context or screenshots.
