fix: check if preview_branch_refs exists #19124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hallidayo is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
MildTomato
reviewed
Nov 22, 2023
| @@ -25,7 25,7 @@ const ProjectCard = ({ | |||
| const { name, ref: projectRef } = project | |||
| const desc = `${project.cloud_provider} | ${project.region}` | |||
|
|
|||
| const isBranchingEnabled = project.preview_branch_refs.length > 0 | |||
| const isBranchingEnabled = project.preview_branch_refs && project.preview_branch_refs.length > 0 | |||
There was a problem hiding this comment.
@joshenlim i suppose this only makes sense if default project is also counted in the preview_branch_refs array
There was a problem hiding this comment.
yeah you're right - the api route for default project probably doesnt have this param hence why it crashed here
joshenlim
reviewed
Nov 23, 2023
apps/studio/components/interfaces/Home/ProjectList/ProjectCard.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshen Lim <[email protected]>
|
Hi @MildTomato & @joshenlim - I've just updated the change to use @joshenlim line. |
|
@Hallidayo a quick conflict there & we should be g2g! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix - Local Dev
What is the current behavior?
Running the development version of Supabase if you go to the main projects dashboard this error is appearing:
What is the new behavior?
Added a check for the variable and now the page loads without error.
Additional context
@MildTomato