Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Edge Runtime global types #79

Merged
merged 2 commits into from
Apr 14, 2024
Merged

feat: add Edge Runtime global types #79

merged 2 commits into from
Apr 14, 2024

Conversation

laktek
Copy link
Contributor

@laktek laktek commented Apr 14, 2024 •
edited
Loading

What kind of change does this PR introduce?

This PR adds a type definition file which can be imported into edge functions to get Edge Runtime specific global types.

Then in an edge function these types can be added as:

/// <reference types="npm:https://esm.sh/@supabase/functions-js/src/edge-runtime.d.ts" />

@coveralls
Copy link

coveralls commented Apr 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8681653994

Details

  • 0 of 45 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-13.4%) to 78.797%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-runtime.d.ts 0 45 0.0%
Totals Coverage Status
Change from base Build 8680872048: -13.4%
Covered Lines: 219
Relevant Lines: 277
💛 - Coveralls

thorwebdev
thorwebdev approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add some typedoc annotations to explain the model parameters. Otherwise LGTM

@laktek laktek merged commit 26a23e0 into main Apr 14, 2024
1 check passed
@laktek laktek deleted the supabase-ai-types branch April 14, 2024 23:44
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorwebdev thorwebdev thorwebdev approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laktek @coveralls @thorwebdev