Remove FTP support, update ruff, tweak API and more. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
commented
Mar 27, 2023
nabobalis
changed the title
nabobalis
force-pushed
the
tweaks
branch
3 times, most recently
from
a1b38ef to
6d2bf9d
Compare
nabobalis
changed the title
nabobalis
changed the title
nabobalis
commented
Apr 4, 2023
nabobalis
force-pushed
the
tweaks
branch
3 times, most recently
from
838e3b7 to
bacf1d8
Compare
nabobalis
force-pushed
the
tweaks
branch
6 times, most recently
from
43fa9f2 to
526f704
Compare
nabobalis
changed the title
nabobalis
changed the title
nabobalis
commented
Jun 13, 2023
| @@ -25,7 +24,7 @@ | |||
| # Send request to the DRMS server | |||
| print("Querying keyword data...\n -> {qstr}") | |||
| segname = "synopMr" | |||
| results, filenames = client.query(qstr, key=drms.const.all, seg=segname) | |||
| results, filenames = client.query(qstr, key=drms.JsocInfoConstants.all.value, seg=segname) | |||
There was a problem hiding this comment.
TODO: Decide if I like this.
nabobalis
force-pushed
the
tweaks
branch
2 times, most recently
from
e831207 to
334a103
Compare
nabobalis
force-pushed
the
tweaks
branch
2 times, most recently
from
bc8b8b7 to
c1d8c21
Compare
nabobalis
force-pushed
the
tweaks
branch
2 times, most recently
from
1aa923d to
6136d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #45
Will release this as 0.7 due the changes.