Skip to content

Commit

Permalink
reincluded open-demo into gulp
Browse files Browse the repository at this point in the history
can be run using npm start
  • Loading branch information
janpaepke committed May 2, 2019
1 parent 3c75501 commit 6aca8f6
Show file tree
Hide file tree
Showing 4 changed files with 72 additions and 22 deletions.
12 changes: 7 additions & 5 deletions dev/todo.md
Original file line number Diff line number Diff line change
@@ -1,3 1,10 @@
# TODO BEFORE PUBLISH
- rework contributing.md
- update CONTRIBUTING.md with a better instructon for PRs (what files to commit etc.)
- update CONTRIBUTING.md with all gulp build options - change to use npx?
- fix google analytics


# Source
- change: make toogle class default behaviour: https://github.com/janpaepke/ScrollMagic/pull/421
- update Reveal on Scroll example to work with above bevhaviour (maybe remove a class instead of adding)
Expand All @@ -14,11 21,6 @@
- add missing tests (core methods, _utils)

# Project
- rework contributing.md
- update CONTRIBUTING.md with a better instructon for PRs (what files to commit etc.)
- update CONTRIBUTING.md with all gulp build options
- fix npm start (gulp open-demo) and add npm build
- fix google analytics
- add missing private docs (global search TODO)
- fix example sourcecode display to show unmodified code (i.e. when SM adds classes it will be shown)
- replace bower with yarn/webpack? concerns examples in readme.md, website and potentially sourcecode
Expand Down
7 changes: 7 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 24,7 @@ var
uglify = require('gulp-uglify'),
jeditor = require('gulp-json-editor'),
beautify = require('gulp-jsbeautifier'),
open = require('open'),

// custom built
log = require('./dev/build/logger'),
Expand Down Expand Up @@ -329,6 330,10 @@ var runKarmaTests = function (cb) {
.start();
}

var openDemo = function () {
return open("./index.html");
}

/* ########################################## */
/* ############# exposed tasks ############## */
/* ########################################## */
Expand All @@ -353,6 358,8 @@ gulp.task('test', runTests);

gulp.task('generate:docs', generateDocs);

gulp.task('open-demo', openDemo);

gulp.task('travis-ci', gulp.series(sourceErrorcheck, buildAll, runKarmaTests));

// Default task for compilation. This is run with `gulp` and no defined task
Expand Down
74 changes: 57 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 38,7 @@
"karma-chrome-launcher": "^2.2.0",
"karma-jasmine": "^1.1.2",
"karma-requirejs": "^1.1.0",
"open": "^6.2.0",
"pretty-bytes": "^5.1.0",
"requirejs": "^2.3.6",
"semver": "^5.5.1",
Expand Down

0 comments on commit 6aca8f6

Please sign in to comment.