Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print messages from window/logMessage into console instead of LSP log panel #2444

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Print messages from window/logMessage into console instead of LSP log panel #2444

merged 2 commits into from
Apr 14, 2024

Conversation

jwortmann
Copy link
Member

I think it's not very useful to print those messages into the LSP log panel, in addition to the payload log. Those lines are just redundant there, for example

LSP-pyright: Received change text document command for closed file file:///d:/code/Python/LspTest/main.py
:: [22:05:28.199] <-  LSP-pyright window/logMessage: {'message': 'Received change text document command for closed file file:///d:/code/Python/LspTest/main.py', 'type': 1}

Instead, if "log_debug" is enabled, I suggest to log them into the console, similar to the other log/debug messages like

LSP: enabled configs: [...]
LSP: starting [...]
LSP: LSP-pyright: supported code action kinds: [...]

Error messages are additionally printed to the status bar (only if "log_debug" setting is enabled).

@jwortmann jwortmann marked this pull request as ready for review April 13, 2024 16:43
predragnikolic
predragnikolic approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@predragnikolic predragnikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@predragnikolic predragnikolic merged commit f497d74 into sublimelsp:main Apr 14, 2024
8 checks passed
@jwortmann jwortmann deleted the log-message branch April 14, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@predragnikolic predragnikolic predragnikolic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwortmann @predragnikolic