Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument "include_declaration" to "lsp_symbol_references" #2275

Merged
merged 3 commits into from
May 30, 2023

Conversation

EmasXP
Copy link
Contributor

@EmasXP EmasXP commented May 19, 2023

Closes #2244

@predragnikolic
Copy link
Member

predragnikolic commented May 25, 2023

Should probably add the include_declaration argument in this file ->

"args": {"side_by_side": false, "force_group": true, "fallback": false, "group": -1},

(I am on mobile, please do a find in project and see if you need to add the argument to other places)

@EmasXP
Copy link
Contributor Author

EmasXP commented May 29, 2023

I added include_declaration as false in Default.sublime-keymap.

The command is referenced here too:

  • Context.sublime-menu
  • Default.sublime-commands
  • Main.sublime-menu

I decided to not add the argument there since no other argument is specified either. Do you want me to add the argument anyway?

@predragnikolic
Copy link
Member

No need to add it there.

@rchl rchl changed the title Adding argument "include_declaration" to "lsp_symbol_references". Add argument "include_declaration" to "lsp_symbol_references" May 30, 2023
@rchl rchl merged commit 53c75bf into sublimelsp:main May 30, 2023
rchl added a commit that referenced this pull request May 30, 2023
* main:
  fix "Error rewriting command" warning triggered on startup (#2277)
  Take font style of sighelp active parameter from color scheme (#2279)
  Add argument "include_declaration" to "lsp_symbol_references" (#2275)
  fix crash on checking excluded folders with missing project data (#2276)
  Fix tagged diagnostics flickering on document changes (#2274)
  Cut 1.24.0
  use class for diagnostic info instead of hardcoding color (#2257)
  Fix package storage path in a docstring description (#2256)
  Use regular font style in sighelp popup if already highlighted by color scheme (#2259)
  update note about custom color scheme rule used for diagnostics (#2254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to pass includeDeclaration as True for textDocument/references
4 participants