Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html-escape diagnostic-related strings #2228

Merged
merged 5 commits into from
Apr 13, 2023
Merged

html-escape diagnostic-related strings #2228

merged 5 commits into from
Apr 13, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Mar 31, 2023 •
edited
Loading

  • Removed unused view argument from format_diagnostic_for_html
  • Escape diagnostic properties when including them in HTML

Fixes #2223

@rchl rchl changed the title html-escape diagnostics related strings html-escape diagnostic-related strings Mar 31, 2023
@predragnikolic
avoid call to make_link in format_completion
964e5a8 
instead just create a link fast with a string
@predragnikolic
Copy link
Member

predragnikolic commented Apr 13, 2023 •
edited
Loading

Does anyone have any comments?
If not, I would like to merge this.

rchl
rchl commented Apr 13, 2023
View reviewed changes
plugin/completion.py Outdated Show resolved Hide resolved
@rchl rchl merged commit 6225b00 into main Apr 13, 2023
@rchl rchl deleted the fix/escape-diagnostics branch April 13, 2023 19:42
rchl added a commit that referenced this pull request Apr 17, 2023
@rchl
Merge branch 'main' into feat/diag-annotations
8657c88 
* main:
  Clear pull diagnostics on file closed (#2224)
  html-escape diagnostic-related strings (#2228)
  Allow style overrides for inlay_hints.css (#2232)
  Fix exception for null response id (#2233)
  Add "outline" as an option for "document_highlight_style" (#2234)
  remove accidentally committed files
  Improve label detail support in completions (#2212)
  Update clojure-lsp docs (#2226)
  Add support for pull diagnostics (#2221)
  update test MockManager after API change
  add a client option for hiding non-project diagnostics (#2218)
  Fix some features might not work with dynamical registration (#2222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@predragnikolic predragnikolic predragnikolic approved these changes

@predrag-codetribe predrag-codetribe predrag-codetribe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid HTML in diagnostics["code"] breaks hover popups.
3 participants
@rchl @predragnikolic @predrag-codetribe