How about removing the _lowercase_driveletter instead? I thought it would solve the duplicate goto-def issue but it looks like servers will have to account for that themselves. Which Intelephense does.

How about removing the _lowercase_driveletter instead? I thought it would solve the duplicate goto-def issue but it looks like servers will have to account for that themselves. Which Intelephense does.

Possibly it would even be safest to uppercase in both cases since the filename_to_uri might be used with file paths that come from somewhere else than ST (either server or user configuration).

Can you add some tests for this in tests/test_url.py so we don't regress in the future?

Possibly it would even be safest to uppercase in both cases since the filename_to_uri might be used with file paths that come from somewhere else than ST (either server or user configuration).

Seems like the pathname2url already does the uppercasing for us if the filename has a lowercase drive letter. I removed the obsolete function.

Can you add some tests for this in tests/test_url.py so we don't regress in the future?

Yes, I guess these tests need to be adjusted now anyway to pass.

I adjusted the outdated test, but I think the tests should already cover the critical cases. Anything more to add there?