-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI again #1679
Enable CI again #1679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously the linux failures should be looked at but the changes look good :)
I'd like to enable it only if succeeds, with no flaky tests. |
The check whether document version has changed after running code actions actually needs to run *after* the code actions were run.
Possibly I'll be jumping the gun but I believe the main issue is fixed. Looks like it was related to
That looks like our issue because after After that fix the I won't have time to continue today (maybe in the evening) but will eventually clean it up. |
It seems that the |
And just when I've said it, mac failed the |
I think it will be pretty stable now. The latest failure was due to missing import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bravo. You win. (I can't approve my own pull request)
Let's see if this works :) SublimeText/UnitTesting#189