Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI again #1679

Merged
merged 48 commits into from
Jun 9, 2021
Merged

Enable CI again #1679

merged 48 commits into from
Jun 9, 2021

Conversation

rwols
Copy link
Member

@rwols rwols commented May 24, 2021

Let's see if this works :) SublimeText/UnitTesting#189

rchl
rchl previously approved these changes May 24, 2021
Copy link
Member

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously the linux failures should be looked at but the changes look good :)

@rwols
Copy link
Member Author

rwols commented May 24, 2021

I'd like to enable it only if succeeds, with no flaky tests.

@rchl rchl closed this Jun 5, 2021
@rchl rchl reopened this Jun 5, 2021
@rchl rchl closed this Jun 5, 2021
@rchl rchl reopened this Jun 5, 2021
@rchl rchl closed this Jun 5, 2021
@rchl rchl reopened this Jun 5, 2021
@rchl rchl closed this Jun 5, 2021
@rchl rchl reopened this Jun 5, 2021
@rchl
Copy link
Member

rchl commented Jun 6, 2021

Possibly I'll be jumping the gun but I believe the main issue is fixed.

Looks like it was related to DocumentSyncListener instance being created with the same View and Buffer ID while the existing one was not del'eted yet. Below you can see that on_close triggers and then there is __init__ with the same IDs but without there being __del__ for the existing one.

DocumentSyncListener.on_close view(View(61)), buffer(168)
ok
DocumentSyncListener.__init__ view(View(62)), buffer(171)
SessionView __del__ config(TEST) buffer_id(168)
TextDocumentTestCase.tearDownClass
DocumentSyncListener.__init__ view(View(61)), buffer(168)

That looks like our issue because after on_close is called, ST has the right to assume that the listener is garbage collected but since we didn't unregister it from WindowsManager, it was being kept alive and messing up some logic.

After that fix the test_publish_diagnostics test is consistently failing which I'm not sure why again. Doesn't look like it should be affected and the server communication looks correct. Will need to check that too...

I won't have time to continue today (maybe in the evening) but will eventually clean it up.

@rchl
Copy link
Member

rchl commented Jun 8, 2021

It seems that the "random" changes commit made it more stable. Probably not 100% but potentially good enough.

@rchl
Copy link
Member

rchl commented Jun 8, 2021

And just when I've said it, mac failed the test_additional_edits_if_session_has_the_resolve_capability test...

@rchl
Copy link
Member

rchl commented Jun 9, 2021

I think it will be pretty stable now. The latest failure was due to missing import.

@rchl rchl closed this Jun 9, 2021
@rchl rchl reopened this Jun 9, 2021
Copy link
Member Author

@rwols rwols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo. You win. (I can't approve my own pull request)

@rwols rwols merged commit 1889ea3 into main Jun 9, 2021
@rwols rwols deleted the fix/ci branch June 9, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants