Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temp disabled config logic #1606

Merged
merged 4 commits into from
Mar 13, 2021
Merged

Conversation

rwols
Copy link
Member

@rwols rwols commented Mar 6, 2021

Putting a configuration into a temporarily disabled state has the major drawback that you can't enable it anymore, unless you close the window and re-open the window.

Instead, disable a failing config via the settings machinery. This way you can enable it again by clicking on Tools > LSP > Enable Language Server In Project.

Copy link
Member

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little skeptical about this because users might not understand how to turn those back on and that will lead to more "support" requests.

Maybe the error message should at least mention the specific command to use for enabling?

plugin/core/windows.py Outdated Show resolved Hide resolved
plugin/core/windows.py Outdated Show resolved Hide resolved
plugin/core/windows.py Outdated Show resolved Hide resolved
@rwols rwols merged commit d878071 into st4000-exploration Mar 13, 2021
@rwols rwols deleted the feat/remove-temp-disabled branch March 13, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants