Require a value when calling resolve function of a Promise #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the value passed to ResolveFunc non-optional. This allows to skip some if-checks when handling receiving resolved value in a fullfill function. This also aligns the behavior with a recent change in Typescript [1]. [1] https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/#resolves-parameters-are-no-longer-optional-in-promises
This reverts commit 725ec67.
|
Tricky one that mypy type error. Even though the ResolveFunc requires an argument now, |
|
What's the plan here? Is this supposed to be merged before #1582 ? |
|
I'd have to figure out how to fix the mypy issue first and so far I'm not sure. |
|
I've made the argument to Promise.[resolve|on_main_thread|on_async_thread] non-optional. You decide if that's an OK solution. I don't hate it, I think being explicit is not a bad thing. |
rwols
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the value passed to ResolveFunc non-optional. This allows to
skip some if-checks when handling resolved value in a fullfill
function.
This also aligns the behavior with a recent change in Typescript [1].
[1] https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/#resolves-parameters-are-no-longer-optional-in-promises