fix: handle undefined mediaDevices #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
requested changes
Dec 13, 2019
xobotyi
approved these changes
Jan 30, 2020
xobotyi
reviewed
Jan 30, 2020
src/util.ts
Outdated
| @@ -1,5 1,5 @@ | |||
| export const isClient = typeof window === 'object'; | |||
|
|
|||
| export const on = (obj: any, ...args: any[]) => obj.addEventListener(...args); | |||
| export const on = (obj: any, ...args: any[]) => obj && obj.addEventListener(...args); | |||
There was a problem hiding this comment.
Not sure if these functions should be touched at all. With your changes in some cases handler bind will silently fail and development or debug will be much harder. Better to have error in that case.
You should leave only changes in src/useMediaDevices.ts, update the PR and ill merge it.
There was a problem hiding this comment.
As you forbid to make changes in your fork repo it should be like so:
useMediaDevices:
import { useEffect, useState } from 'react';
import { noop, off, on } from './util';
const useMediaDevices = () => {
const [state, setState] = useState({});
useEffect(() => {
if (!navigator.mediaDevices) return;
let mounted = true;
const onChange = () => {
navigator.mediaDevices
.enumerateDevices()
.then(devices => {
mounted &&
setState({
devices: devices.map(({ deviceId, groupId, kind, label }) => ({ deviceId, groupId, kind, label })),
});
})
.catch(noop);
};
on(navigator.mediaDevices, 'devicechange', onChange);
onChange();
return () => {
mounted = false;
off(navigator.mediaDevices, 'devicechange', onChange);
};
}, []);
return state;
};
export default useMediaDevices;util
export const isClient = typeof window === 'object';
export const on = (obj: any, ...args: any[]) => obj.addEventListener(...args);
export const off = (obj: any, ...args: any[]) => obj.removeEventListener(...args);
export const noop = () => {};
|
@streamich maybe make a breaking change and change the returning signature? |
|
🎉 This PR is included in version 13.22.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: useMediaDevices(): TypeError: Cannot read property 'addEventListener' of undefined
Type of change
Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).