Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(volume): toJSON now accepts the asBuffer parameter #952

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat(volume): toJSON now accepts the asBuffer parameter #952

merged 1 commit into from
Sep 22, 2023

Conversation

shorwood
Copy link
Contributor

@shorwood shorwood commented Sep 18, 2023

I had to recreate the PR since I fumbled a bit and force-pushed at some point

code.png

Context

Review feedback from the #880.
Note that this PR is isolated and does not include #880

Actions

Extended vol.toJSON so it can now output the virtual directory structure as a map of Buffer if the asBuffer parameter is set to true

`vol.toJSON` can now output the virtual directory structure
as a map of `Buffer` if the `asBuffer` parameter is set to
`true`. The default behavior is still to output a map of
`utf8` strings.
@shorwood shorwood changed the title feat(volume): now handling Buffer as volume content feat(volume): toJSON now accepts the asBuffer parameter Sep 19, 2023
@G-Rath G-Rath merged commit 91a3742 into streamich:master Sep 22, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
# [4.4.0](v4.3.0...v4.4.0) (2023-09-22)

### Features

* **volume:** `toJSON` now accepts the `asBuffer` parameter ([#952](#952)) ([91a3742](91a3742))
* **volume:** implement readv and writev ([#946](#946)) ([966e17e](966e17e))
@streamich
Copy link
Owner

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants