Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: deprecated set-output command #272

Merged
merged 4 commits into from
Nov 25, 2022
Merged

Conversation

yihong0618
Copy link
Collaborator

Copy link
Collaborator

@jsamoocha jsamoocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lwasser
Copy link
Collaborator

lwasser commented Nov 24, 2022

@yihong0618 this is so awesome thank you. Are you able to update the changelog.md file as well and then we can merge this? Many thanks.

Also as a learning opportunity for me there is one part that you added that I don't understand. if you could help me understand what it is doing, i'd appreciate it :) Thank you so much!

@lwasser lwasser merged commit acc6e93 into stravalib:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants