Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badges and copy README to main Strapi package for NPM #10398

Merged
merged 2 commits into from
May 31, 2021

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented May 27, 2021

What does it do?

  • Removed the old Travis badge and swapped the Slack one for the Discord one
  • Copied README to the strapi package root to update the NPM page (Suggested by @vcoisne )

Why is it needed?

Badges were broken

How to test it?

N/A

Related issue(s)/PR(s)

N/A

Removed the old Travis badge and swapped the Slack one for the Discord one
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #10398 (2d70772) into master (6b8aedf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10398    /-   ##
=======================================
  Coverage   57.84%   57.84%           
=======================================
  Files         184      184           
  Lines        6395     6395           
  Branches     1394     1394           
=======================================
  Hits         3699     3699           
  Misses       2233     2233           
  Partials      463      463           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 57.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8aedf...2d70772. Read the comment docs.

Signed-off-by: Derrick Mehaffy <[email protected]>
@derrickmehaffy derrickmehaffy changed the title Update Readme to remove old badges Update badges and copy README to main Strapi package for NPM May 27, 2021
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 5207606 into master May 31, 2021
@alexandrebodin alexandrebodin deleted the readme/badgeFix branch May 31, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants