UI: Add preloading to stories highlighted in the sidebar #17964
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit df77b98. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
There was a problem hiding this comment.
I tried this out and found two problem:
-
When mousing over the sidebar, it only preloads at the story level, which is "too late" as a sibling story will already have been loaded. (similar when using the keyboard).
-
It doesn't do anything in the search panel. I thought we planned to do similar behaviour on mouse/keyboard selection?
|
@tmeasday I think I made all the requested changes |
There was a problem hiding this comment.
I tested in different projects using webpack4 and 5 and the behavior is super awesome!
There was one scenario that didn't go really well (kind of expected to be honest @tmeasday) which is when using LazyCompilation. If the user hovers over 10 stories fast, then webpack goes haywire:
webpack5lazycompilation.mov
|
Should report as a bug to webpack I guess. I propose we add a debounce here: |
|
Ok! Wanna add it in this PR or another next cycle? |
|
I'd be in favor of merging this, and creating a new task for next cycle |
auto map the ref id in lib/api when calling emit emit preload event when hovering over sidebar items or selecting them with the keyboard
ndelangen
force-pushed
the
norbert/sb-28-prefetch-csf-files-on-hover-select-via
branch
from
cbc0e45
to
1aa9f79
Compare
ndelangen
deleted the
norbert/sb-28-prefetch-csf-files-on-hover-select-via
branch
What I did
Optimizations: