Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Print validation results even when --errors flag is passed #2634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bitswamp
Copy link

Summary

My team wants to integrate the Prism proxy into our CI pipeline, without having to modify all our existing e2e tests to print out the validation errors in case of failure.

This PR changes the behaviour of the --errors flag so that in addition to returning validation errors in the response body (the existing behaviour), the validation failures are also printed in the prism proxy output (similar to the current behaviour without the --errors flag).

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A (I'm open to adding a test, but the change didn't affect any existing tests)
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

Proxy output with --errors before change:

2024-11-15_13-59

Proxy output with --errors after change:

2024-11-15_13-58

@bitswamp bitswamp requested a review from a team as a code owner November 15, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant