Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support oem field of thermal and fan #178

Merged
merged 1 commit into from
Jul 1, 2022
Merged

feat: support oem field of thermal and fan #178

merged 1 commit into from
Jul 1, 2022

Conversation

daadajuan
Copy link
Contributor

No description provided.

@daadajuan daadajuan force-pushed the feat/support_oem_field_of_thermal_and_fan branch from 61a87aa to ea4c0d1 Compare June 3, 2022 07:26
@daadajuan daadajuan mentioned this pull request Jun 3, 2022
Closed
@daadajuan daadajuan force-pushed the feat/support_oem_field_of_thermal_and_fan branch from ea4c0d1 to 2713762 Compare June 3, 2022 08:06
stmcginnis
stmcginnis reviewed Jun 14, 2022
View reviewed changes
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay checking this out. This looks great! Thanks for working on it.

There are a few issues that the linter job caught (make lint). If you can address those, then I think this is good to go.

Thanks!

@stmcginnis
Copy link
Owner

Hi @daadajuan - will you be able to update this to address the lint issues?

@daadajuan daadajuan force-pushed the feat/support_oem_field_of_thermal_and_fan branch from 2713762 to f1a5829 Compare July 1, 2022 02:55
@daadajuan
Copy link
Contributor Author

@stmcginnis Sorry for the late, I have resolved the lint issues, please check it, thanks a lot.

stmcginnis
stmcginnis approved these changes Jul 1, 2022
View reviewed changes
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daadajuan!!

@stmcginnis stmcginnis merged commit 46c07e7 into stmcginnis:main Jul 1, 2022
@nwaizer nwaizer mentioned this pull request Jul 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daadajuan @stmcginnis