add oem property for root service object #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @leslie-qiwa, but please see #146 for an example of how we've decided to approach OEM data. |
Signed-off-by: Leslie Qi Wang <[email protected]>
|
@stmcginnis I pushed new change, and let me know if it is align with #146 or not |
stmcginnis
approved these changes
Jun 18, 2021
| @@ -175,6 178,7 @@ func (serviceroot *Service) UnmarshalJSON(b []byte) error { | |||
| Links struct { | |||
| Sessions common.Link | |||
| } | |||
| Oem json.RawMessage // OEM message will be stored here | |||
There was a problem hiding this comment.
I don't think we would need this because it can just be unmarshalled directly to the object's property. But no big deal, that can be cleaned up later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leslie Qi Wang [email protected]