Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dscquery output DSC_REPLICATE column by default #95

Closed
gaow opened this issue Mar 9, 2018 · 1 comment
Closed

dscquery output DSC_REPLICATE column by default #95

gaow opened this issue Mar 9, 2018 · 1 comment

Comments

@gaow
Copy link
Member

gaow commented Mar 9, 2018

Currently this info is only available when users query it. We should make it default when number of replicates is greater than 1.

gaow added a commit that referenced this issue Mar 13, 2018
@gaow
Copy link
Member Author

gaow commented Mar 13, 2018

Okey with this patch eb34e7a now every query will report DSC replicates under column name DSC (one of the few reserved words I now abuse for replicate column names). The patch, albeit short, is non-trivial -- in fact the entire query part is not straightforward SQL at all, due in large part to our group mechanism, and any changes to the code would possibly break things. I pushed the changes anyways and close the ticket for now. It is very crucial at this point to have bigger test suite for dscrutils::dscquery.

@gaow gaow closed this as completed Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant