Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker image is pinned when already pinned #1954

Closed
varunsh-coder opened this issue Mar 1, 2023 · 3 comments
Closed

Docker image is pinned when already pinned #1954

varunsh-coder opened this issue Mar 1, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@varunsh-coder
Copy link
Member

See this example:
https://github.com/fleetdm/fleet/pull/10205/files/0d98d9f31120b05f57d757d6ac96bce5632bd6d9..5ce95d8bf8496f39eac930a9d90c2e8af27b3caf

We need to check if the image is already pinned, then, it should not be pinned again.
@varunsh-coder varunsh-coder added the bug Something isn't working label Mar 1, 2023
@varunsh-coder varunsh-coder mentioned this issue Mar 1, 2023
Closed
2 tasks
@varunsh-coder
Copy link
Member Author

@Devils-Knight can you please take this up? Do add a test case for this scenario.

@Devils-Knight
Copy link
Contributor

@varunsh-coder I think there is already code in place for this scenario, view here.
The file above mentioned has pinned the image twice so it just removed one of the hash.

@Devils-Knight Devils-Knight mentioned this issue Mar 9, 2023
Merged
@varunsh-coder
Copy link
Member Author

This is released. Good work @Devils-Knight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varunsh-coder @Devils-Knight