Remove rlib #166
Merged
Remove rlib #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Nov 3, 2022
liquidity_pool_router/Cargo.toml
Outdated
| @@ -5,7 +5,7 @@ edition = "2021" | |||
| publish = false | |||
|
|
|||
| [lib] | |||
| crate-type = ["cdylib", "rlib"] | |||
| crate-type = ["cdylib"] | |||
|
|
|||
| [features] | |||
| testutils = ["soroban-sdk/testutils", "soroban-auth/testutils","soroban-liquidity-pool-contract/testutils","dep:ed25519-dalek", "dep:sha2", "dep:stellar-xdr"] | |||
There was a problem hiding this comment.
I"m surprised this builds and runs. Under some conditions I"ve seen crates fail to import other crates if they were only a cdylib and not a rlib. It looks like this crate is importing soroban-liquidity-pool-contract, and that crate has no rlib.
There was a problem hiding this comment.
Ah actually this contract only uses soroban-liquidity-pool-contract through the wasm file. All references to it in Cargo.toml can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all use of rlib. The easiest way to do this was to have the router contracts always create the non-router contracts in wasm.